Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #107376 to fix potential bincode breakage and rustc-perf benchmark. #109183

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Revert #107376 to fix potential bincode breakage and rustc-perf benchmark. #109183

merged 1 commit into from
Mar 16, 2023

Conversation

lqd
Copy link
Member

@lqd lqd commented Mar 15, 2023 •
edited
Loading

#107376 caused rustc-perf's webrender benchmark to break, by regressing on the bincode-1.3.3 crate.

This PR is a draft revert in case we can't land a fix soon enough, and we'd like to land the revert instead

(Though I myself think it'd be safer to do the revert, and run crater when relanding #107376.)

cc @aliemjay

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 15, 2023
@lqd lqd mentioned this pull request Mar 15, 2023
Merged
@compiler-errors
Copy link
Member

Though I myself think it'd be safer to do the revert, and run crater when relanding #107376.

I also think that this is probably the safest approach as well.

@compiler-errors
Copy link
Member

Anyways, if you'd like to unblock perf sooner than later, r=me.

@lqd lqd marked this pull request as ready for review March 15, 2023 19:21
@lqd
Copy link
Member Author

lqd commented Mar 15, 2023

if you'd like to unblock perf sooner than later

That wasn't the primary motivation -- bincode seems popular and the next nightly might cause a bunch of breakage otherwise -- but now that you mention it, it's another good reason to do so :)

We're likely going to miss the nightly cutoff, unfortunately.

We could add the MCVE as a test here, but if we plan to run crater anyways, it can be added when we revert this revert.

Thanks @compiler-errors.

r? @compiler-errors @bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Mar 15, 2023

📌 Commit 5ad1083 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2023
@lqd lqd changed the title Prepare possible revert of #107376 Revert #107376 to fix potential bincode breakage and rustc-perf benchmark. Mar 15, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 15, 2023
@matthiaskrgr
Rollup merge of rust-lang#109183 - lqd:revert-107376, r=compiler-errors
7805446 
Revert rust-lang#107376 to fix potential `bincode` breakage and `rustc-perf` benchmark.

rust-lang#107376 caused `rustc-perf`'s `webrender` benchmark to break, by regressing on the `bincode-1.3.3` crate.

~~This PR is a draft revert in case we can't land a fix soon enough, and we'd like to land the revert instead~~

(Though I myself think it'd be safer to do the revert, and run crater when relanding rust-lang#107376.)

cc `@aliemjay`
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 15, 2023
Closed
@dtolnay dtolnay mentioned this pull request Mar 16, 2023
Closed
@compiler-errors
Copy link
Member

@bors p=1

@dtolnay dtolnay mentioned this pull request Mar 16, 2023
Merged
@bors
Copy link
Contributor

bors commented Mar 16, 2023

⌛ Testing commit 5ad1083 with merge 18e305d...

aliemjay
aliemjay approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@aliemjay aliemjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the revert and the MCVE!

I haven't thought enough about how this blocks perf. I should've prioritized the issue more.

@dtolnay dtolnay linked an issue Mar 16, 2023 that may be closed by this pull request
nightly-2023-03-16 fails to compile bincode: "add_outlives_bounds: unexpected regions" #109199
Closed
@bors
Copy link
Contributor

bors commented Mar 16, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 18e305d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 16, 2023
@bors bors merged commit 18e305d into rust-lang:master Mar 16, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 16, 2023
@lqd lqd deleted the revert-107376 branch March 16, 2023 07:46
@lqd
Copy link
Member Author

lqd commented Mar 16, 2023

I haven't thought enough about how this blocks perf. I should've prioritized the issue more.

To be clear @aliemjay, perf.rlo wasn't blocked per se, the collector ignores benchmarks that fail but still measures the others. We just wouldn't see regressions or improvements to that specific crate. It also means that a real world crate was broken by a PR, in a way that CI didn't catch (but crater usually would) and that can be more problematic than the lack of benchmarking data for a short period of time.

@weihanglo weihanglo mentioned this pull request Mar 16, 2023
Merged
@MingweiSamuel MingweiSamuel mentioned this pull request Mar 16, 2023
Closed
@striezel striezel mentioned this pull request Mar 16, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (18e305d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.1% [0.6%, 1.4%] 7
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.2% [2.8%, 3.5%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@lqd
Copy link
Member Author

lqd commented Mar 17, 2023

Even if no triage needs to be done per-se: this is a revert, and the tt-muncher benchmark is currently noisy.

@gurry gurry mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliemjay aliemjay aliemjay approved these changes

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

nightly-2023-03-16 fails to compile bincode: "add_outlives_bounds: unexpected regions"
6 participants
@lqd @compiler-errors @bors @rust-timer @aliemjay @rustbot